Files
marketplaces/e2e/smoke.spec.ts

54 lines
2.2 KiB
TypeScript
Raw Permalink Normal View History

feat: stand up E2E harness, fix a real bootstrap bug it found Track Q Q1/Q4 (docs/PRODUCT-PLAN-v3.1-DELIVERY-PLAN.md). No E2E existed before this. Playwright chosen - no existing test runner preference, and it needs zero extra infra beyond the dev server this repo already has. - playwright.config.ts, package.json e2e/e2e:ui/e2e:report scripts - e2e/smoke.spec.ts app boots, no console errors (network 404s from the absent backend are filtered - expected, not a bug) - e2e/currency-switch.spec.ts Track Q Q4: switching currency must change the displayed price VALUE, not just the label next to it. Written specifically so the upcoming checkout money-truth rewrite (frontend backlog F10-F16, which replaces client-side FX math with a server-computed total) has a regression net under it before that rewrite starts. The first run found a real, current bug: @marketplaces/auth ships plain tsc output (dist/index.js), not Angular Package Format, so it carries no compiled Ivy DI metadata. Any class-based provider from it - not just the Ed25519 Noop stub, AuthService itself hit the same failure - forces Angular to JIT-compile at runtime, which throws immediately when @angular/compiler isn't loaded. That breaks app bootstrap outright, for real users, not just this test. Fixed here with the minimum honest scope: - src/main.ts: import '@angular/compiler' before bootstrap, so JIT works everywhere the package is injected, not just at one call site - src/app/app.config.ts: useFactory instead of useClass for the Noop Ed25519 provider, since it has zero constructor deps and doesn't need Angular to derive metadata for it at all - angular.json: raised the initial-bundle hard-error budget 1.5MB -> 1.8MB, because the compiler import made a correct build refuse to complete. A build that fails outright is worse than a bundle that's honestly larger than it should be. The real fix belongs in the vitanovaPackages auth repo: publish via ng-packagr so consumers get Ivy-compiled output and none of this is necessary. Do not remove the compiler import until that ships - see the comment left in main.ts. Also fixed a genuine test defect while getting this to a real green: the page renders duplicate .currency-option elements (desktop/mobile variants of the same selector), so the first attempt at this test clicked into a hidden duplicate and silently no-opped. Scoped the click to .currency-dropdown.open and added an explicit poll for the DOM to reflect the new currency before reading it back, rather than trusting a fixed timeout. Verified: 3/3 E2E green, 115/115 unit tests green, arch:check clean, production build succeeds. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-08-18 13:46:43 +04:00
import { expect, test } from '@playwright/test';
/** First E2E test in this repo. If this fails, nothing else in the suite matters. */
test.describe('smoke', () => {
test('storefront boots with no console errors', async ({ page }) => {
const errors: string[] = [];
// pageerror catches uncaught exceptions - always a real bug, always kept.
page.on('pageerror', err => errors.push(err.message));
page.on('console', msg => {
if (msg.type() !== 'error') {
return;
}
// "Failed to load resource" is Chrome's own message for a failed
// network request (404/502/etc), not application code. With
// environment.useMockData: false and no live backend behind this dev
// server (docs/backend/BACKEND-HANDOFF.md), every /api/ call 404s by
// design - that is a backend-availability fact, not something this
// smoke test exists to catch. A real app-level console.error still
// fails this test.
if (/^Failed to load resource/.test(msg.text())) {
return;
}
errors.push(msg.text());
});
await page.goto('/');
await expect(page.locator('body')).toBeVisible();
// Give the bootstrap fetch + first render cycle time to settle before
// asserting on the error list, or this is a race against app.config.ts.
await page.waitForLoadState('networkidle');
expect(errors, `console errors on first paint: ${errors.join('\n')}`).toEqual([]);
});
test('renders the placeholder home page when the marketplace is unpublished', async ({ page }) => {
// This suite runs against the mock-data build (see comment at the top of
// playwright.config.ts), so MockBootstrapProvider fetches this static
// asset rather than a live /bootstrap endpoint - that's the URL to
// intercept here, not the real API path.
await page.route('**/assets/mock/bootstrap/bootstrap.json', route =>
route.fulfill({
status: 200,
contentType: 'application/json',
body: JSON.stringify({ schemaVersion: '1.0.0', generatedAt: new Date().toISOString(), published: false }),
})
);
await page.goto('/');
await expect(page.getByText('Welcome to Marketplace')).toBeVisible();
});
feat: stand up E2E harness, fix a real bootstrap bug it found Track Q Q1/Q4 (docs/PRODUCT-PLAN-v3.1-DELIVERY-PLAN.md). No E2E existed before this. Playwright chosen - no existing test runner preference, and it needs zero extra infra beyond the dev server this repo already has. - playwright.config.ts, package.json e2e/e2e:ui/e2e:report scripts - e2e/smoke.spec.ts app boots, no console errors (network 404s from the absent backend are filtered - expected, not a bug) - e2e/currency-switch.spec.ts Track Q Q4: switching currency must change the displayed price VALUE, not just the label next to it. Written specifically so the upcoming checkout money-truth rewrite (frontend backlog F10-F16, which replaces client-side FX math with a server-computed total) has a regression net under it before that rewrite starts. The first run found a real, current bug: @marketplaces/auth ships plain tsc output (dist/index.js), not Angular Package Format, so it carries no compiled Ivy DI metadata. Any class-based provider from it - not just the Ed25519 Noop stub, AuthService itself hit the same failure - forces Angular to JIT-compile at runtime, which throws immediately when @angular/compiler isn't loaded. That breaks app bootstrap outright, for real users, not just this test. Fixed here with the minimum honest scope: - src/main.ts: import '@angular/compiler' before bootstrap, so JIT works everywhere the package is injected, not just at one call site - src/app/app.config.ts: useFactory instead of useClass for the Noop Ed25519 provider, since it has zero constructor deps and doesn't need Angular to derive metadata for it at all - angular.json: raised the initial-bundle hard-error budget 1.5MB -> 1.8MB, because the compiler import made a correct build refuse to complete. A build that fails outright is worse than a bundle that's honestly larger than it should be. The real fix belongs in the vitanovaPackages auth repo: publish via ng-packagr so consumers get Ivy-compiled output and none of this is necessary. Do not remove the compiler import until that ships - see the comment left in main.ts. Also fixed a genuine test defect while getting this to a real green: the page renders duplicate .currency-option elements (desktop/mobile variants of the same selector), so the first attempt at this test clicked into a hidden duplicate and silently no-opped. Scoped the click to .currency-dropdown.open and added an explicit poll for the DOM to reflect the new currency before reading it back, rather than trusting a fixed timeout. Verified: 3/3 E2E green, 115/115 unit tests green, arch:check clean, production build succeeds. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-08-18 13:46:43 +04:00
});