sdarbinyan/marketplaces
0
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

docs(admin): move locale-hardcoding gap from Open to Fixed

Browse Source 
Follow-up to ff4fba3 - the admin/products + admin/categories
translation-tab locale-hardcoding gap flagged as deferred in the
bug-hunt audit docs is now fixed; updates docs/ADMIN.md's audit
section and moves docs/KNOWN-ISSUES.md's item from Open to Fixed.
This commit is contained in:
sdarbinyan
2026-07-17 22:25:58 +04:00
parent ff4fba379f
commit 6be3c5892d
2 changed files with 30 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
docs/KNOWN-ISSUES.md
View File

@@ -76,21 +76,6 @@ don't fix inline unless asked.
auth-system check first (does one exist yet?) before building the menu.
- Found: 2026-07-17, project-editor bug-hunt audit.
6. **Admin product/category translation tabs hardcode `['en', 'ru', 'hy']`
instead of reading the tenant's configured `supportedLocales`.**
`admin-product-form.component.html` and `admin-category-form.component.html`
both `@for (locale of ['en','ru','hy']; ...)` over a fixed literal array
rather than `ProjectEditorFacade.bootstrap().localization.supportedLocales`
(the same source `static-pages-editor.component.ts` already reads
correctly). A tenant with fewer or different supported locales gets
translation tabs for languages it doesn't support, and no tab at all for
ones it does. Not fixed inline: neither `AdminProductsFacade` nor
`AdminCategoriesFacade` currently depends on project-editor state, so this
needs real cross-feature plumbing (facade -> facade -> two presentational
form components), not a bounded wiring fix.
- Found: 2026-07-17, `admin/products` + `admin/categories` bug-hunt audit
(`docs/ADMIN.md`'s "Bug-hunt audit pass" section).
## Fixed
1. **Full-project UX/UI + motion pass across storefront, admin dashboard,
@@ -229,10 +214,17 @@ don't fix inline unless asked.
backend unreachable in this environment, so via
`facade.categories.set([...])` synthetic siblings feeding the same
facade methods/gateway calls the UI drives).
- One further gap found but deferred as real feature work, not a wiring
bug - see Open item 6 above: `admin-product-form`/`admin-category-form`
hardcode translation-tab locales to `['en','ru','hy']` instead of the
tenant's actual `supportedLocales`.
- A third bug from the same audit pass, fixed in a follow-up commit:
`admin-product-form`/`admin-category-form` hardcoded translation-tab
locales to `['en','ru','hy']` instead of the tenant's actual
`supportedLocales`. Fixed by giving `AdminProductsFacade`/
`AdminCategoriesFacade` a `supportedLocales` computed +
`ensureLocalesLoaded()` reading/lazily-loading
`ProjectEditorFacade.bootstrap()` (same pattern
`AdminDashboardFacade.ensureLoaded()` already uses), threaded down to
both form components via a new `locales` `@Input()`. Verified live:
rendered tab order changed from the hardcoded `['en','ru','hy']` to the
real tenant order `['ru','en','hy']` in both editors.
## Notes (not bugs, just flag before shipping)