fix(builder): WCAG 2.1 AA accessibility fixes
RC A11Y-01 audit pass, Builder (project-editor) + content-management static
pages editor. Builds on 4ebc15f's composition pass without redoing it.
- Skip link: Builder's /edit and /edit/:section routes render outside the
storefront app-shell (isAdminRoute() branch has no skip link/landmark, only
a bare router-outlet, unlike the storefront's app.html) - added a
"skip to content" link targeting a new #builder-main-content landmark on
project-editor-page.component, reusing the existing adminShell.skipToContent
key and global .skip-link style. Nav landmark already had aria-label
(builder.appName) from the prior pass, verified correct.
- Save bar: added role="status"/aria-live="polite" to the save/publish status
block and role="status" to the draft-restored notice so save/publish state
changes and draft recovery are announced to screen readers (previously
silent DOM updates).
- Media picker (shared, used by both Builder and static-pages editor): upload
error message had no aria-live wiring - added role="alert".
- HTML editor (marketplace-html-editor): the contenteditable rich-text surface
had no accessible role/name - added role="textbox", aria-multiline="true",
aria-label.
- Drag-and-drop keyboard fallback (WCAG 2.1.1): homepage-section's block list
and footer-section's column list + per-column link list use Angular CDK
drag-drop (cdkDrag/cdkDropList), which has no built-in keyboard reordering.
Added move-up/move-down icon buttons (disabled at the first/last boundary),
matching the existing pattern already used by widgets-section and
navigation-section.
- Color picker: the swatch <input type="color"> had no accessible name (only
the paired text input was labelled via app-form-field) - added explicit
ariaLabel bindings to all 8 color-picker instances in theme-section.
- Languages: the new-locale code input relied on a placeholder ("de") as its
only accessible name - added ariaLabel + new builder.newLanguageLabel i18n
key (en/ru/hy).
- Undefined CSS var --color-primary (never defined anywhere, silently used its
hardcoded hex fallback and never responded to tenant theming - same
recurring bug class as 4ebc15f) - remapped to the real --primary-color token
in marketplace-html-editor, homepage-section, and section.shared (7 usages).
- role="alert" added to all 11 validation-error <p class="editor-error">
occurrences across footer/homepage/languages/navigation/preview/widgets
sections and the static-pages editor, so field/section validation messages
are announced.
- scope="col" added to preview-section's change-summary table headers.
Flagged, not fixed (design-system decisions, matching the storefront pass's
precedent):
- Save bar's --warning-color/--error-color/--info-color text fail WCAG AA
4.5:1 in some themes - same genuine brand semantic colors flagged (not
fixed) in fb1afb7's storefront pass; needs a deliberate token decision,
not a Builder-specific issue.
- locale-tabs (app-locale-tabs, shared) has role="tablist"/"tab" and
aria-selected but no roving-tabindex/arrow-key navigation - matches the
same partial-tablist pattern already accepted for product-tabs in the
storefront pass; all tabs remain natively Tab-focusable, so this meets
4.1.2/2.1.1 without the full ARIA authoring-practice pattern.
Verified: npx tsc --noEmit clean; npm run build green (only the pre-existing
bundle-budget warning, unrelated to this pass).
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
@@ -127,6 +127,18 @@ export class ProjectEditorFooterSectionComponent {
|
||||
this.setColumns(columns);
|
||||
}
|
||||
|
||||
/** Keyboard-operable fallback for the drag-and-drop column reorder above (WCAG 2.1.1). */
|
||||
moveColumn(columnId: string, direction: -1 | 1): void {
|
||||
const columns = [...this.columns()];
|
||||
const index = columns.findIndex(column => column.id === columnId);
|
||||
const targetIndex = index + direction;
|
||||
if (index === -1 || targetIndex < 0 || targetIndex >= columns.length) {
|
||||
return;
|
||||
}
|
||||
moveItemInArray(columns, index, targetIndex);
|
||||
this.setColumns(columns);
|
||||
}
|
||||
|
||||
addLink(columnId: string): void {
|
||||
const link: FooterLinkConfig = { id: `link-${Date.now()}`, label: '', pageKey: this.availablePages()[0]?.id ?? '', url: '' };
|
||||
this.setColumns(this.columns().map(column => column.id === columnId ? { ...column, links: [...column.links, link] } : column));
|
||||
@@ -152,6 +164,22 @@ export class ProjectEditorFooterSectionComponent {
|
||||
this.setColumns(this.columns().map(c => c.id === columnId ? { ...c, links } : c));
|
||||
}
|
||||
|
||||
/** Keyboard-operable fallback for the drag-and-drop link reorder above (WCAG 2.1.1). */
|
||||
moveLink(columnId: string, linkId: string, direction: -1 | 1): void {
|
||||
const column = this.columns().find(c => c.id === columnId);
|
||||
if (!column) {
|
||||
return;
|
||||
}
|
||||
const links = [...column.links];
|
||||
const index = links.findIndex(link => link.id === linkId);
|
||||
const targetIndex = index + direction;
|
||||
if (index === -1 || targetIndex < 0 || targetIndex >= links.length) {
|
||||
return;
|
||||
}
|
||||
moveItemInArray(links, index, targetIndex);
|
||||
this.setColumns(this.columns().map(c => c.id === columnId ? { ...c, links } : c));
|
||||
}
|
||||
|
||||
linkSourceMode(link: FooterLinkConfig): 'page' | 'custom' {
|
||||
return link.pageKey ? 'page' : 'custom';
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user