From a0d3f086c10ae23c2a02e03c600dbf42ca7877cf Mon Sep 17 00:00:00 2001
From: sdarbinyan <sdarbinyan@4pay.ru>
Date: Sun, 19 Jul 2026 23:57:49 +0400
Subject: [PATCH] fix(admin): polish categories
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Add accessible names to select-all, per-row select, and per-row
visibility-toggle checkboxes in the table view — none had them,
including the visibility toggle whose <label> wrapped only the input
with no text content (empty accessible name). Tree/grid views already
had aria-label on their row checkboxes; table view was the gap.

New adminCategories.selectAllRows/selectRow/toggleVisibility keys
added across en/ru/hy.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
---
 .../components/admin-categories-list.component.html         | 6 +++---
 src/app/i18n/en.ts                                          | 3 +++
 src/app/i18n/hy.ts                                          | 3 +++
 src/app/i18n/ru.ts                                          | 3 +++
 src/app/i18n/translations.ts                                | 3 +++
 5 files changed, 15 insertions(+), 3 deletions(-)

diff --git a/src/app/features/admin/categories/components/admin-categories-list.component.html b/src/app/features/admin/categories/components/admin-categories-list.component.html
index b7f8e89..8056983 100644
--- a/src/app/features/admin/categories/components/admin-categories-list.component.html
+++ b/src/app/features/admin/categories/components/admin-categories-list.component.html
@@ -129,7 +129,7 @@
     <app-table [class.density-compact]="density === 'compact'">
       <thead>
         <tr>
-          <th><input type="checkbox" (change)="selectAll.emit($any($event.target).checked)" /></th>
+          <th><input type="checkbox" [attr.aria-label]="'adminCategories.selectAllRows' | translate" (change)="selectAll.emit($any($event.target).checked)" /></th>
           <th>{{ 'adminCategories.title' | translate }}</th>
           @if (visibleColumns.includes('slug')) { <th>{{ 'adminCategories.slug' | translate }}</th> }
           @if (visibleColumns.includes('items')) { <th>{{ 'adminCategories.items' | translate }}</th> }
@@ -142,7 +142,7 @@
       <tbody>
         @for (category of flatCategories; track category.id) {
           <tr [class.deleted]="category.deletedAt">
-            <td><input type="checkbox" [checked]="isSelected(category.id)" (change)="selectionChange.emit({ id: category.id, checked: $any($event.target).checked })" /></td>
+            <td><input type="checkbox" [checked]="isSelected(category.id)" [attr.aria-label]="('adminCategories.selectRow' | translate) + ': ' + category.title" (change)="selectionChange.emit({ id: category.id, checked: $any($event.target).checked })" /></td>
             <td>{{ category.icon }} {{ category.title }}</td>
             @if (visibleColumns.includes('slug')) { <td>{{ category.slug }}</td> }
             @if (visibleColumns.includes('items')) { <td>{{ category.itemsCount }}</td> }
@@ -150,7 +150,7 @@
               <td><app-badge [variant]="category.status === 'published' ? 'success' : 'neutral'">{{ ('adminCategories.status.' + category.status) | translate }}</app-badge></td>
             }
             @if (visibleColumns.includes('visibility')) {
-              <td><label class="check"><input type="checkbox" [checked]="category.visible" (change)="toggleVisible.emit({ id: category.id, visible: $any($event.target).checked })" /></label></td>
+              <td><label class="check"><input type="checkbox" [checked]="category.visible" [attr.aria-label]="('adminCategories.toggleVisibility' | translate) + ': ' + category.title" (change)="toggleVisible.emit({ id: category.id, visible: $any($event.target).checked })" /></label></td>
             }
             <td class="health-cell"><app-category-health-widget [items]="healthItems(category)" [completionPercent]="health(category).completionPercent" [compact]="true" /></td>
             <td class="actions">
diff --git a/src/app/i18n/en.ts b/src/app/i18n/en.ts
index ea00c17..6c717ae 100644
--- a/src/app/i18n/en.ts
+++ b/src/app/i18n/en.ts
@@ -1448,6 +1448,9 @@ export const en: Translations = {
     replaceImage: 'Replace image',
     search: 'Search categories…',
     showDeleted: 'Show deleted',
+    selectAllRows: 'Select all categories',
+    selectRow: 'Select category',
+    toggleVisibility: 'Toggle visibility',
     create: 'Create category',
     edit: 'Edit category',
     title: 'Title',
diff --git a/src/app/i18n/hy.ts b/src/app/i18n/hy.ts
index 28ddec5..eaace23 100644
--- a/src/app/i18n/hy.ts
+++ b/src/app/i18n/hy.ts
@@ -1443,6 +1443,9 @@ export const hy: Translations = {
     replaceImage: 'Փոխարինել պատկերը',
     search: 'Փնտրել կատեգորիաներ…',
     showDeleted: 'Ցույց տալ ջնջվածները',
+    selectAllRows: 'Ընտրել բոլոր կատեգորիաները',
+    selectRow: 'Ընտրել կատեգորիան',
+    toggleVisibility: 'Փոխել տեսանելիությունը',
     create: 'Ստեղծել կատեգորիա',
     edit: 'Խմբագրել կատեգորիան',
     title: 'Անուն',
diff --git a/src/app/i18n/ru.ts b/src/app/i18n/ru.ts
index cde1b2f..e4d4f8a 100644
--- a/src/app/i18n/ru.ts
+++ b/src/app/i18n/ru.ts
@@ -1443,6 +1443,9 @@ export const ru: Translations = {
     replaceImage: 'Заменить изображение',
     search: 'Поиск категорий…',
     showDeleted: 'Показать удалённые',
+    selectAllRows: 'Выбрать все категории',
+    selectRow: 'Выбрать категорию',
+    toggleVisibility: 'Переключить видимость',
     create: 'Создать категорию',
     edit: 'Редактировать категорию',
     title: 'Название',
diff --git a/src/app/i18n/translations.ts b/src/app/i18n/translations.ts
index f36db51..bcbf915 100644
--- a/src/app/i18n/translations.ts
+++ b/src/app/i18n/translations.ts
@@ -1456,6 +1456,9 @@ export interface Translations {
     replaceImage: string;
     search: string;
     showDeleted: string;
+    selectAllRows: string;
+    selectRow: string;
+    toggleVisibility: string;
     create: string;
     edit: string;
     title: string;