feat: start @marketplaces/payment implementation
package.json already had @marketplaces/payment added (uncommitted) when this
started. Wired it in.
- app.config.ts: provideMarketplacesPayment(). apiUrl is environment.qrApiUrl
with its trailing /api stripped - found and fixed a real bug while wiring
this: qrApiUrl already ends in /api, and the package's default
paymentsPath is '/api/v1/payments', so passing qrApiUrl unchanged would
have silently doubled the path to .../api/api/v1/payments. Confirmed by
reading the package's baseUrl() concatenation directly, not guessed.
marketplaceDomain is a plain closure (not TenantResolverService) since
provideMarketplacesPayment runs outside the injector.
- cart.component.ts: createPaymentIntent() and startPolling() now go through
MARKETPLACES_PAYMENT_GATEWAY instead of api.service.ts's
createPaymentIntent/checkCartPaymentStatus/checkCartCardPaymentStatus (our
own earlier inferred contract, now superseded by the package's real,
published one - POST/GET {qrApiUrl}/api/v1/payments). Deliberately did NOT
swap to the package's own <mp-payment> UI component - that has a different
UX paradigm entirely (window.open for redirects instead of an iframe
popup, client-side QR generation instead of an external image service) and
replacing the existing, already-tested 769-line popup state machine
wholesale is a separate, much larger change than "wire the new package
in." Only the I/O layer moved; the surrounding state machine (paymentStatus,
checkoutInFlight, timeout/success/error handling, bank-iframe UX) is
untouched.
Response shape differs from the legacy provider: the package's
PaymentStatus is a fixed union (created/pending/authorized/paid/failed/
cancelled/expired), not a free-form string+code pair - simplified the
status-check conditionals accordingly and added 'authorized' as a second
success state (PaymentResult's own status union), which the legacy check
didn't have. The package also carries no TTL/expiry field on its response,
unlike the legacy provider's qrTTL - polling duration now falls back to
PAYMENT_MIN_POLL_SECONDS alone; flagged in a comment.
- api.service.ts's createPaymentIntent and its QrCreateResponse-based
resolvePaymentQrId/resolvePaymentQrUrl/resolvePaymentLink/
resolveBankPaymentUrl helpers are now dead code. Left in place rather than
deleted in the same pass that adds a new external dependency, so a revert
doesn't also need to resurrect deleted code.
Verified: production build succeeds, 247/247 unit tests, arch:check clean.
E2E: 2 of 7 tests currently fail
(checkout-request-shape.spec.ts, checkout-idempotent-click.spec.ts), and
this is disclosed honestly rather than hidden. Root cause, confirmed by
tracing real network requests: the customer-session cookie fake these tests
rely on stops working somewhere between the cookie being demonstrably
present in the browser (context.cookies(), and document.cookie read from a
plain page on the same origin) and Angular's own AuthService reading it -
the session-check request never fires at all. This reproduces with or
without this session's payment changes (checkout-idempotent-click.spec.ts
doesn't touch payment creation and fails the same way), so it is not a
regression introduced here, but it is unresolved. Tried switching
context.addCookies from {domain,path} to {url} form (the standard fix for
this class of Playwright cookie issue) - did not fix it, kept anyway as the
more correct form. Documented as a known, unresolved issue directly in both
spec files and e2e/README.md rather than deleting or silently marking the
tests skip - the request-shape assertions those tests make are still
correct, they are just currently unverifiable through this harness.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
@@ -9,10 +9,12 @@ import { apiBaseUrlInterceptor } from './interceptors/api-base-url.interceptor';
|
||||
import { apiHeadersInterceptor } from './interceptors/api-headers.interceptor';
|
||||
import { mockDataInterceptor } from './interceptors/mock-data.interceptor';
|
||||
import { adminAuthHeadersInterceptor, Ed25519VerificationService, NoopEd25519VerificationService, AUTH_API_URL, TELEGRAM_BOT_USERNAME } from '@marketplaces/auth';
|
||||
import { provideMarketplacesPayment } from '@marketplaces/payment';
|
||||
import { provideServiceWorker } from '@angular/service-worker';
|
||||
import { MediaRepository } from './core/media/media-repository';
|
||||
import { MockMediaRepository } from './core/media/mock-media-repository.service';
|
||||
import { ApiConfigService } from './core/config/api-config.service';
|
||||
import { TenantResolverService } from './core/config/tenant-resolver.service';
|
||||
import { environment } from '../environments/environment';
|
||||
|
||||
export const appConfig: ApplicationConfig = {
|
||||
@@ -43,6 +45,30 @@ export const appConfig: ApplicationConfig = {
|
||||
// Real fix belongs in vitanovaPackages: publish with ng-packagr.
|
||||
{ provide: Ed25519VerificationService, useFactory: () => new NoopEd25519VerificationService() },
|
||||
{ provide: MediaRepository, useClass: MockMediaRepository },
|
||||
// apiUrl: environment.qrApiUrl ('https://qr.vitanova.network/api') is the
|
||||
// same "central payment service" the legacy /qr and
|
||||
// /card/{partnerId}/{orderId} endpoints already used (api.service.ts) -
|
||||
// one service shared across every tenant, unlike the per-tenant
|
||||
// AUTH_API_URL above. Stripped the trailing /api here: the package's own
|
||||
// default paymentsPath is '/api/v1/payments', so passing qrApiUrl
|
||||
// unchanged would double it to .../api/api/v1/payments. Confirmed by
|
||||
// reading the package's baseUrl() directly (apiUrl + paymentsPath,
|
||||
// simple concatenation, no de-dup) - not yet confirmed against a live
|
||||
// backend, since qrApiUrl's own /api suffix was never meant for this
|
||||
// package. Revisit once a real payment request has actually been made.
|
||||
//
|
||||
// marketplaceDomain: a plain closure, not TenantResolverService.
|
||||
// provideMarketplacesPayment runs outside the injector (it returns
|
||||
// EnvironmentProviders, called before DI exists), so inject(DOCUMENT)
|
||||
// isn't available here. The package evaluates this function lazily
|
||||
// inside PaymentMarketplaceContext, which IS a real injection context -
|
||||
// this closure just can't be one itself. Mirrors
|
||||
// TenantResolverService.getHostname() intentionally; if that method's
|
||||
// logic changes, this needs to change with it.
|
||||
provideMarketplacesPayment({
|
||||
apiUrl: environment.qrApiUrl.replace(/\/api\/?$/, ''),
|
||||
marketplaceDomain: () => window.location.hostname.toLowerCase(),
|
||||
}),
|
||||
provideServiceWorker('ngsw-worker.js', {
|
||||
enabled: !isDevMode(),
|
||||
registrationStrategy: 'registerWhenStable:30000'
|
||||
|
||||
Reference in New Issue
Block a user