sdarbinyan/marketplaces
0
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: reports page never read facade.error(), silently showed 0/0

Browse Source 
AdminAnalyticsFacade.error() already existed but the reports page
template never checked it - a load failure just rendered the summary
cards with default/zero values, looking like a legitimate empty
report instead of a failure.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
sdarbinyan
2026-08-13 08:46:17 +04:00
parent 1e84d67e24
commit d3d6632375
2 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/app/features/admin/reports/pages/admin-reports-page.component.html
View File

@@ -6,6 +6,8 @@
} }
<span class="sr-only">{{ 'common.loading' | translate }}</span> <span class="sr-only">{{ 'common.loading' | translate }}</span>
</div> </div>
} @else if (facade.error()) {
<app-empty-state [title]="'common.errorTitle' | translate" [description]="'common.errorDescription' | translate" />
} @else { } @else {
<div class="report-grid"> <div class="report-grid">
<div class="report-card"> <div class="report-card">

3
src/app/features/admin/reports/pages/admin-reports-page.component.ts
View File

@@ -3,11 +3,12 @@ import { AdminAnalyticsFacade } from '../../analytics/facade/admin-analytics.fac
import { TranslatePipe } from '../../../../i18n/translate.pipe'; import { TranslatePipe } from '../../../../i18n/translate.pipe';
import { ButtonComponent } from '../../../../shared/ui/button/button.component'; import { ButtonComponent } from '../../../../shared/ui/button/button.component';
import { SkeletonComponent } from '../../../../shared/ui/skeleton/skeleton.component'; import { SkeletonComponent } from '../../../../shared/ui/skeleton/skeleton.component';
import { EmptyStateComponent } from '../../../../shared/ui/empty-state/empty-state.component';
@Component({ @Component({
selector: 'app-admin-reports-page', selector: 'app-admin-reports-page',
standalone: true, standalone: true,
imports: [TranslatePipe, ButtonComponent, SkeletonComponent], imports: [TranslatePipe, ButtonComponent, SkeletonComponent, EmptyStateComponent],
templateUrl: './admin-reports-page.component.html', templateUrl: './admin-reports-page.component.html',
styleUrls: ['./admin-reports-page.component.scss'], styleUrls: ['./admin-reports-page.component.scss'],
changeDetection: ChangeDetectionStrategy.OnPush changeDetection: ChangeDetectionStrategy.OnPush