From d4eb25dd4b355236443fa3ccbfe6951e2b8ebb48 Mon Sep 17 00:00:00 2001 From: sdarbinyan Date: Fri, 24 Jul 2026 10:47:09 +0400 Subject: [PATCH] docs: add RELEASE_REPORT.md for release-candidate walkthrough Consolidates 3 live browser walkthrough commits (storefront, builder, backoffice): 2 P0s found and fixed (app-wide query-param routing bug, Categories CRUD completely broken end-to-end), 6 P1s, remaining items flagged for a content/design decision rather than fixed unilaterally. Co-Authored-By: Claude Sonnet 5 --- docs/RELEASE_REPORT.md | 47 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 47 insertions(+) create mode 100644 docs/RELEASE_REPORT.md diff --git a/docs/RELEASE_REPORT.md b/docs/RELEASE_REPORT.md new file mode 100644 index 0000000..7ae5c52 --- /dev/null +++ b/docs/RELEASE_REPORT.md @@ -0,0 +1,47 @@ +# Release Candidate Report + +Live browser walkthrough of every route across Storefront, Builder, Backoffice — "pretend this ships tomorrow." No redesign, no route/API changes. Three sequential commits on branch `B2B` (not pushed): + +| Commit | Scope | +|---|---| +| `0a1acbd` | Storefront | +| `2cbb62a` | Builder | +| `907ac2c` | Backoffice | + +`npm run build` verified green after every commit. `npx tsc --noEmit` clean throughout. Dev server run against the local mock bootstrap + dev-proxy `/api/*` (real seeded data, expected setup — not a bug). + +## P0s found and fixed + +Two genuine ship-blockers, both app-wide in effect despite being caught during a single-surface walkthrough: + +1. **Query-param routing broken on every route (`src/app/guards/language.guard.ts`).** The legacy-URL redirect built the target with `router.createUrlTree([...])` using a single path-segment string with the query string baked in, so it got percent-encoded into the path instead of parsed as query params — `/edit/branding?devBypassAdmin=true` became `/ru/edit/branding%3FdevBypassAdmin%3Dtrue`, a dead route. This guard runs on every top-level route, so **any bookmarked or shared deep link carrying query params was silently broken app-wide** — not a Builder-only bug, just discovered there. Fixed with `router.parseUrl()`. + +2. **Categories CRUD completely broken end-to-end (`admin-categories-gateway.token.ts`).** `RuntimeProviderStrategyService.getBackofficeProviderMode()` has no `isLocalhost()` fallback (unlike `getBootstrapProviderMode()`), so the categories gateway always resolved to the real HTTP `AdminCategoriesApiGateway` instead of the purpose-built local mock — in an environment with no real backend (see `docs/PERFORMANCE_REPORT.md`/`docs/ACCESSIBILITY_REPORT.md` context: backend integration is still PLANNED). Combined with `saveDraft()` having no error handler, every create/publish click **silently failed** — nothing saved, the dirty flag never cleared, and the unsaved-changes guard then blocked navigation with zero feedback to the admin user. Fixed by wiring the token to the already-defined `getCategoryProviderMode()` + adding the same `isLocalhost()` mock fallback. Live-verified: created/edited/reordered categories, all persist correctly now. Production/non-localhost behavior unchanged. + +## P1s found and fixed + +**Storefront:** +- Cart item description rendered a bare `...` when an item had no description. +- Compare table showed raw internal stock enum values (`high`/`low`) instead of localized labels. +- Zero-result search stacked confusing "browse categories" empty-category messaging on top of the search's own "nothing found" message. +- Footer "About" link 404'd (`/about` vs actual route `/about-us`) — fixed in mock bootstrap. +- Missing fallback placeholder image for items with no photo — added `public/assets/images/placeholder.svg`. + +**Builder:** +- `resetDraft()` discarded the draft but never resynced `lastSavedBootstrap`, so the save bar immediately showed "unsaved changes" right after a full reset. + +**Backoffice:** +- Categories list mislabeled its Edit button "Edit product" (wrong i18n key — `adminProducts.edit` instead of the already-correct `adminCategories.edit`). Not part of the tracked ~178-key i18n gap, since the right key already existed. + +## Flagged, not fixed (need a decision, not a code fix) + +- **Storefront**: Footer "Contacts" link has no static-page content in mock data at all (unlike About, which was just a route-name mismatch) — needs a content decision. `/images/*.webp` 404s on product cards are numeric-ID paths meant to resolve against a real backend/CDN not present in local dev — expected dev-only gap, not a bug. Russian pluralization ("1 товаров" vs "1 товар") — cosmetic, out of scope. +- **Builder**: the static page editor's actual body-content WYSIWYG editor lives inside a collapsed `
` under "Advanced", mislabeled "Source HTML (advanced)" though it's the only way to edit page content — works correctly once found, relocating/relabeling it is a navigation/design decision for product sign-off. + +## Verification + +Live browser walkthrough performed in all three passes (not static-only) — every route above was actually navigated, forms actually submitted, CRUD actually exercised (categories create/edit/delete/reorder, cart add/remove, compare/wishlist add), both desktop and mobile viewports checked, console + network inspected after each navigation. `tsc --noEmit` and `npm run build` green after each commit. + +## Cross-reference + +This pass sits on top of four prior audits this cycle: `docs/UI-COMPOSITION-REVIEW.md` (composition), `docs/STORE_FRONT_UX_REVIEW.md` / `docs/STORE_REVIEW.md` (storefront polish), `docs/PERFORMANCE_REPORT.md` (bundle/reactivity), `docs/ACCESSIBILITY_REPORT.md` (WCAG 2.1 AA). Known, already-tracked gaps not re-reported here: ~178 missing `adminXxx.*` i18n keys, Theme Mode has no runtime effect, `dynamic-renderer/` unwired, `primeng` still in `package.json` pending an unrelated lockfile blocker — all in `docs/KNOWN-ISSUES.md`.