Commit Graph

5 Commits

Author SHA1 Message Date
sdarbinyan
2cbb62a9cc fix(builder): release-candidate walkthrough fixes
- Legacy no-lang-prefix URLs with a query string (e.g. the dev
  ?devBypassAdmin=true bypass itself, or any bookmarked/shared deep link
  into the Builder) got their query string percent-encoded into the path
  instead of preserved (language.guard.ts) - router.createUrlTree([...])
  treats a single array element as a literal path segment, so
  `/edit/branding?devBypassAdmin=true` became
  `/ru/edit/branding%3FdevBypassAdmin%3Dtrue`, a 0-result route. Switched
  to router.parseUrl() on the full redirect string so path, query params,
  and fragment are parsed and preserved correctly. This guard runs on
  every top-level route in the app (not just Builder), so this was
  silently breaking any legacy URL with a query string app-wide.
- "Reset draft" (Sbrosit' chernovik) left the save-bar showing "unsaved
  changes" immediately after the reset, even though the reset already
  discarded everything and cleared the persisted localStorage draft
  (project-editor.facade.ts resetDraft()) - it updated the in-memory
  bootstrap and cleared the draft but never resynced lastSavedBootstrap,
  which the dirty computed diffs against. Now resetDraft() also resets
  lastSavedBootstrap to match, so the status bar correctly reads as clean
  right after a full discard.

Verified live via browser walkthrough of every Builder section (General,
Branding, Theme, Header, Footer, Homepage, Widgets, Static Pages,
Languages, Features, Navigation, Preview) plus save/publish/undo/redo/
reset-section/reset-draft/draft-restore flows, the media picker dialog,
and the Homepage block / Footer column keyboard-fallback reorder buttons
(WCAG 2.1.1 fallback added in the prior a11y pass) - all functioned
correctly end-to-end, no console errors, no untranslated i18n keys, no
unexpected 4xx/5xx, no layout overflow at desktop or mobile widths.

Investigated and flagged, not fixed (needs a design decision, not a bug
fix): the static page's actual body content editor
(app-marketplace-html-editor, per-locale) is not on the page editor's
"Content" tab at all - it only has title/hero-image/thumbnail fields.
The real WYSIWYG/HTML editor is nested inside a collapsed <details>
disclosure under the "Advanced" tab, labeled "Source HTML (advanced)" as
if it were a raw-HTML power-user fallback, when it is in fact the only
way to edit a static page's body content. Functions correctly once
found/expanded; the placement/labeling just doesn't match the "Content"
tab a merchant would expect it under, and moving it is a navigation
change beyond this pass's fix-what's-broken scope.

npx tsc --noEmit and npm run build both green.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-07-24 10:12:14 +04:00
sdarbinyan
4bf0666fd1 perf(app): lazy-load i18n translation packs, drop dead items-carousel component
RC PERF-01 bundle audit follow-up on 61a5714.

- i18n: ru/en/hy translation packs (346 KB raw combined) were all
  statically imported in TranslateService and shipped in the initial
  bundle regardless of the visitor's language. Now only 'ru' (platform
  default) is bundled eagerly; 'en'/'hy' are dynamic import()s. The
  language route guard (languageGuard) awaits preloadLanguage() before
  activating the route, so translations are always fully loaded before
  any component renders - no flash of untranslated/fallback content.
- widget-host.service.ts: import UnknownWidgetComponent directly instead
  of via the widgets/ui barrel (index.ts re-exports 6 widgets).
- Deleted src/app/components/items-carousel/* - confirmed dead (zero
  references anywhere, verified via knip and grep), the only consumer
  of primeng/primeicons in the app. Removed the now-unused
  `@import 'primeicons/primeicons.css'` from styles.scss (no primeicons
  CSS classes used elsewhere). primeng/primeicons remain listed in
  package.json/package-lock.json - npm CLI in this environment is
  blocked by an unrelated, pre-existing broken `barry-cache` devDependency
  (ETARGET on `npm install`/`npm uninstall`), so the lockfile could not be
  safely regenerated. Flagged, not fixed.

Routes audit (app.routes.ts): all storefront/builder/backoffice feature
routes already use loadComponent/loadChildren; nothing eagerly imported.
No route changes needed.

Lucide icons (icon-registry.ts): already named/tree-shakeable imports
from @lucide/angular, not a full-library import. No change needed.

Before/after (npm run build, production):
- Initial bundle raw: 1.47 MB -> 1.12 MB (-350 KB / -24%)
- Initial bundle transfer (est.): 263.59 kB -> 221.51 kB (-42 kB / -16%)
- Budget overage: 769.22 kB over -> 416.84 kB over (still exceeds the
  700 KB budget; project-editor-page-component (320 kB),
  catalog-container-component (126 kB), product-details-container
  (88 kB), cart-component (61 kB) lazy chunks unchanged - no safe
  mechanical split identified within scope, see PERF-01 report for
  detail).

Verified: npx tsc --noEmit clean, npm run build green (warning only,
no errors).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-07-24 08:19:13 +04:00
sdarbinyan
e4206d8abc added language routing system 2026-02-26 22:23:08 +04:00
sdarbinyan
c0ca8cdf2d revert: remove language routing (was breaking navigation)
- Reverted app.routes.ts to original simple routing
- Removed language guard
- Language routing needs more comprehensive implementation
2026-01-22 23:31:14 +04:00
sdarbinyan
cb895f68cd fix: improve phone/contact link visibility in novo theme
- Changed contact labels from green to text-secondary color
- Changed contact values/links from green to text-primary with hover effect
- Added proper hover state for all contact card child elements
- Fixed readability issue where green text was on green-tinted background
2026-01-22 23:28:31 +04:00