Files
marketplaces/src/app/features/website
sdarbinyan 3a0b1a3746 fix(search): app-skeleton/app-empty-state for live /search results, icon-only close buttons
/search routes to CatalogContainerComponent + CatalogSearchResultsComponent
(app.routes.ts:45-47) - confirmed the live search surface (pages/search/* is
unrouted dead code per KNOWN-ISSUES.md item 13, not touched here).

- search-results.component: hand-rolled `.skeleton-card` shimmer (hardcoded
  hex gradient colors, duplicate keyframes) replaced with the shared
  app-skeleton primitive the dead pages/search copy already used, but the
  live component never got. Bare `<div class="empty-state"><h3>/<p></div>`
  replaced with app-empty-state + app-icon, matching CatalogEmptyStateComponent's
  established pattern elsewhere in the same feature.
- Added distinct empty-state messaging: a too-short query (<3 chars, mirrors
  the existing minSearchLength/isQueryTooShort convention from the dead
  pages/search/search.component.ts) now shows "Enter at least N characters"
  instead of being indistinguishable from a genuine no-results-for-X state,
  which now shows the query and a retry hint (search.noResults/noResultsFor/
  noResultsHint/minLength i18n keys already existed, just unused on this path).
- catalog-container.component.html: icon-only close/remove buttons (filter
  drawer, sort sheet, grid sheet, saved-search chip) rendered a literal "x"
  text character with no app-icon - now use app-icon name="x".

Debounce (220ms, search.facade.ts), URL query-param sync, keyboard
arrow-key suggestion navigation (role=combobox/aria-activedescendant), and
filter/sort discoverability were all verified already correct on this path,
no changes needed.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-07-25 20:16:09 +04:00
..