d27c10dd17
package.json already had @marketplaces/payment added (uncommitted) when this
started. Wired it in.
- app.config.ts: provideMarketplacesPayment(). apiUrl is environment.qrApiUrl
with its trailing /api stripped - found and fixed a real bug while wiring
this: qrApiUrl already ends in /api, and the package's default
paymentsPath is '/api/v1/payments', so passing qrApiUrl unchanged would
have silently doubled the path to .../api/api/v1/payments. Confirmed by
reading the package's baseUrl() concatenation directly, not guessed.
marketplaceDomain is a plain closure (not TenantResolverService) since
provideMarketplacesPayment runs outside the injector.
- cart.component.ts: createPaymentIntent() and startPolling() now go through
MARKETPLACES_PAYMENT_GATEWAY instead of api.service.ts's
createPaymentIntent/checkCartPaymentStatus/checkCartCardPaymentStatus (our
own earlier inferred contract, now superseded by the package's real,
published one - POST/GET {qrApiUrl}/api/v1/payments). Deliberately did NOT
swap to the package's own <mp-payment> UI component - that has a different
UX paradigm entirely (window.open for redirects instead of an iframe
popup, client-side QR generation instead of an external image service) and
replacing the existing, already-tested 769-line popup state machine
wholesale is a separate, much larger change than "wire the new package
in." Only the I/O layer moved; the surrounding state machine (paymentStatus,
checkoutInFlight, timeout/success/error handling, bank-iframe UX) is
untouched.
Response shape differs from the legacy provider: the package's
PaymentStatus is a fixed union (created/pending/authorized/paid/failed/
cancelled/expired), not a free-form string+code pair - simplified the
status-check conditionals accordingly and added 'authorized' as a second
success state (PaymentResult's own status union), which the legacy check
didn't have. The package also carries no TTL/expiry field on its response,
unlike the legacy provider's qrTTL - polling duration now falls back to
PAYMENT_MIN_POLL_SECONDS alone; flagged in a comment.
- api.service.ts's createPaymentIntent and its QrCreateResponse-based
resolvePaymentQrId/resolvePaymentQrUrl/resolvePaymentLink/
resolveBankPaymentUrl helpers are now dead code. Left in place rather than
deleted in the same pass that adds a new external dependency, so a revert
doesn't also need to resurrect deleted code.
Verified: production build succeeds, 247/247 unit tests, arch:check clean.
E2E: 2 of 7 tests currently fail
(checkout-request-shape.spec.ts, checkout-idempotent-click.spec.ts), and
this is disclosed honestly rather than hidden. Root cause, confirmed by
tracing real network requests: the customer-session cookie fake these tests
rely on stops working somewhere between the cookie being demonstrably
present in the browser (context.cookies(), and document.cookie read from a
plain page on the same origin) and Angular's own AuthService reading it -
the session-check request never fires at all. This reproduces with or
without this session's payment changes (checkout-idempotent-click.spec.ts
doesn't touch payment creation and fails the same way), so it is not a
regression introduced here, but it is unresolved. Tried switching
context.addCookies from {domain,path} to {url} form (the standard fix for
this class of Playwright cookie issue) - did not fix it, kept anyway as the
more correct form. Documented as a known, unresolved issue directly in both
spec files and e2e/README.md rather than deleting or silently marking the
tests skip - the request-shape assertions those tests make are still
correct, they are just currently unverifiable through this harness.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
60 lines
2.2 KiB
JSON
60 lines
2.2 KiB
JSON
{
|
|
"name": "dexarmarket",
|
|
"version": "0.0.0",
|
|
"scripts": {
|
|
"ng": "ng",
|
|
"start": "ng serve",
|
|
"dexar": "ng serve --configuration=development --port 4200",
|
|
"start:dexar": "ng serve --configuration=development --port 4200",
|
|
"build": "ng build",
|
|
"build:dexar": "ng build --configuration=production",
|
|
"test": "ng test --watch=false --browsers=ChromeHeadlessNoSandbox",
|
|
"test:coverage": "ng test --watch=false --browsers=ChromeHeadlessNoSandbox --code-coverage",
|
|
"watch": "ng build --watch --configuration development",
|
|
"arch:check:boundaries": "node tools/architecture/check-boundaries.mjs",
|
|
"arch:check:cycles": "npx --yes madge --circular --extensions ts src/app --ts-config tsconfig.app.json",
|
|
"arch:check": "npm run arch:check:boundaries ; npm run arch:check:cycles",
|
|
"barry": "barry-cache",
|
|
"barry:validate": "barry-cache validate",
|
|
"barry:resume": "barry-cache resume",
|
|
"barry:finalize": "barry-cache finalize",
|
|
"barry:failure": "barry-cache failure",
|
|
"e2e": "playwright test",
|
|
"e2e:ui": "playwright test --ui",
|
|
"e2e:report": "playwright show-report"
|
|
},
|
|
"private": true,
|
|
"dependencies": {
|
|
"@angular/animations": "22.0.8",
|
|
"@angular/cdk": "22.0.6",
|
|
"@angular/common": "22.0.8",
|
|
"@angular/compiler": "22.0.8",
|
|
"@angular/core": "22.0.8",
|
|
"@angular/forms": "22.0.8",
|
|
"@angular/platform-browser": "22.0.8",
|
|
"@angular/router": "22.0.8",
|
|
"@angular/service-worker": "22.0.8",
|
|
"@marketplaces/auth": "git+https://sources.vitanova.network/sdarbinyan/vitanovaPackages.git#release/auth",
|
|
"@marketplaces/payment": "git+https://sources.vitanova.network/sdarbinyan/vitanovaPackages.git#release/payment",
|
|
"rxjs": "~7.8.0",
|
|
"tslib": "^2.8.0",
|
|
"zone.js": "~0.16.0"
|
|
},
|
|
"devDependencies": {
|
|
"@angular/build": "22.0.8",
|
|
"@angular/cli": "22.0.8",
|
|
"@angular/compiler-cli": "22.0.8",
|
|
"@playwright/test": "^1.62.1",
|
|
"@types/jasmine": "~5.1.0",
|
|
"barry-cache": "^0.9.3",
|
|
"istanbul-lib-instrument": "^6.0.3",
|
|
"jasmine-core": "~5.5.0",
|
|
"karma": "~6.4.0",
|
|
"karma-chrome-launcher": "~3.2.0",
|
|
"karma-coverage": "^2.2.1",
|
|
"karma-jasmine": "~5.1.0",
|
|
"karma-jasmine-html-reporter": "~2.1.0",
|
|
"typescript": "~6.0.3"
|
|
}
|
|
}
|