21443d34a0
Some checks failed
Architecture Governance / architecture (push) Has been cancelled
Track Q Q1/Q4 (docs/PRODUCT-PLAN-v3.1-DELIVERY-PLAN.md). No E2E existed
before this. Playwright chosen - no existing test runner preference, and it
needs zero extra infra beyond the dev server this repo already has.
- playwright.config.ts, package.json e2e/e2e:ui/e2e:report scripts
- e2e/smoke.spec.ts app boots, no console errors (network 404s from the
absent backend are filtered - expected, not a bug)
- e2e/currency-switch.spec.ts Track Q Q4: switching currency must change
the displayed price VALUE, not just the label next
to it. Written specifically so the upcoming
checkout money-truth rewrite (frontend backlog
F10-F16, which replaces client-side FX math with a
server-computed total) has a regression net under
it before that rewrite starts.
The first run found a real, current bug: @marketplaces/auth ships plain tsc
output (dist/index.js), not Angular Package Format, so it carries no compiled
Ivy DI metadata. Any class-based provider from it - not just the Ed25519
Noop stub, AuthService itself hit the same failure - forces Angular to
JIT-compile at runtime, which throws immediately when @angular/compiler
isn't loaded. That breaks app bootstrap outright, for real users, not just
this test.
Fixed here with the minimum honest scope:
- src/main.ts: import '@angular/compiler' before bootstrap, so JIT works
everywhere the package is injected, not just at one call site
- src/app/app.config.ts: useFactory instead of useClass for the Noop
Ed25519 provider, since it has zero constructor deps and doesn't need
Angular to derive metadata for it at all
- angular.json: raised the initial-bundle hard-error budget 1.5MB -> 1.8MB,
because the compiler import made a correct build refuse to complete. A
build that fails outright is worse than a bundle that's honestly larger
than it should be.
The real fix belongs in the vitanovaPackages auth repo: publish via
ng-packagr so consumers get Ivy-compiled output and none of this is
necessary. Do not remove the compiler import until that ships - see the
comment left in main.ts.
Also fixed a genuine test defect while getting this to a real green: the
page renders duplicate .currency-option elements (desktop/mobile variants of
the same selector), so the first attempt at this test clicked into a hidden
duplicate and silently no-opped. Scoped the click to .currency-dropdown.open
and added an explicit poll for the DOM to reflect the new currency before
reading it back, rather than trusting a fixed timeout.
Verified: 3/3 E2E green, 115/115 unit tests green, arch:check clean,
production build succeeds.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
59 lines
2.1 KiB
JSON
59 lines
2.1 KiB
JSON
{
|
|
"name": "dexarmarket",
|
|
"version": "0.0.0",
|
|
"scripts": {
|
|
"ng": "ng",
|
|
"start": "ng serve",
|
|
"dexar": "ng serve --configuration=development --port 4200",
|
|
"start:dexar": "ng serve --configuration=development --port 4200",
|
|
"build": "ng build",
|
|
"build:dexar": "ng build --configuration=production",
|
|
"test": "ng test --watch=false --browsers=ChromeHeadlessNoSandbox",
|
|
"test:coverage": "ng test --watch=false --browsers=ChromeHeadlessNoSandbox --code-coverage",
|
|
"watch": "ng build --watch --configuration development",
|
|
"arch:check:boundaries": "node tools/architecture/check-boundaries.mjs",
|
|
"arch:check:cycles": "npx --yes madge --circular --extensions ts src/app --ts-config tsconfig.app.json",
|
|
"arch:check": "npm run arch:check:boundaries ; npm run arch:check:cycles",
|
|
"barry": "barry-cache",
|
|
"barry:validate": "barry-cache validate",
|
|
"barry:resume": "barry-cache resume",
|
|
"barry:finalize": "barry-cache finalize",
|
|
"barry:failure": "barry-cache failure",
|
|
"e2e": "playwright test",
|
|
"e2e:ui": "playwright test --ui",
|
|
"e2e:report": "playwright show-report"
|
|
},
|
|
"private": true,
|
|
"dependencies": {
|
|
"@angular/animations": "22.0.8",
|
|
"@angular/cdk": "22.0.6",
|
|
"@angular/common": "22.0.8",
|
|
"@angular/compiler": "22.0.8",
|
|
"@angular/core": "22.0.8",
|
|
"@angular/forms": "22.0.8",
|
|
"@angular/platform-browser": "22.0.8",
|
|
"@angular/router": "22.0.8",
|
|
"@angular/service-worker": "22.0.8",
|
|
"@marketplaces/auth": "git+https://sources.vitanova.network/sdarbinyan/vitanovaPackages.git#release/auth",
|
|
"rxjs": "~7.8.0",
|
|
"tslib": "^2.8.0",
|
|
"zone.js": "~0.16.0"
|
|
},
|
|
"devDependencies": {
|
|
"@angular/build": "22.0.8",
|
|
"@angular/cli": "22.0.8",
|
|
"@angular/compiler-cli": "22.0.8",
|
|
"@playwright/test": "^1.62.1",
|
|
"@types/jasmine": "~5.1.0",
|
|
"barry-cache": "^0.9.3",
|
|
"istanbul-lib-instrument": "^6.0.3",
|
|
"jasmine-core": "~5.5.0",
|
|
"karma": "~6.4.0",
|
|
"karma-chrome-launcher": "~3.2.0",
|
|
"karma-coverage": "^2.2.1",
|
|
"karma-jasmine": "~5.1.0",
|
|
"karma-jasmine-html-reporter": "~2.1.0",
|
|
"typescript": "~6.0.3"
|
|
}
|
|
}
|