de6bef8e9a
Some checks failed
Architecture Governance / architecture (push) Has been cancelled
Delivery plan Q9: "set a justified coverage floor and CI gate. Deliberately unset today." Both parts of that were still true - karma.conf.js had no check thresholds, and architecture-governance.yml built and checked boundaries but never invoked `ng test` at all. Floor set 5 points below the measured level right after this session's facade-test pass (43.3%/29.0%/34.1%/43.7% statements/branches/functions/ lines): 40/25/30/40. A deliberate floor, not an aspiration - meant to be ratcheted up as coverage grows, and to fail a PR that drops below it rather than silently accept a lower number. Verified the gate actually fails, not just logs a warning: set statements to an impossible 99% locally, confirmed `npm run test:coverage` exits 1 (my first attempt at this check was wrong - piping through `tail` meant the $? I read back was tail's exit code, not npm's; fixed by capturing it directly). Restored the real floor and confirmed a clean exit 0 before committing. CI changes: added the Setup Chrome + coverage-gated test step karma.conf.js's CHROME_BIN needs (its fallback is a Windows path, useless on ubuntu-latest), plus an E2E step. Structurally verified locally (no tabs, step count, manual read-through) - a real GitHub Actions run on Anthropic's infrastructure could not be executed from this session, so this is not confirmed end-to-end the way the coverage gate itself was. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>